feat(coder-labs/modules/codex): add mcp_config_remote_path for remote MCP server configurations#894
Conversation
|
/coder-agents-review |
![coder-agents-review[bot]](https://avatars.githubusercontent.com/in/3454270?s=60&v=4){kind=small}
There was a problem hiding this comment.
First-pass review (Netero). 1 P2, 1 P3, 1 Nit.
The feature is well-scoped: a clean addition of remote MCP config fetching with a solid integration test that exercises both success and failure paths. The README documentation explains the behavior and caveats.
This is a first-pass review only. These are mechanical findings from Netero. The full review panel has not yet reviewed this PR and will review after these findings are addressed.
🤖 This review was automatically generated with Coder Agents.
- Guard jq usage with command -v check; emit a clear error and skip the remote MCP fetch when jq is not available (DEREM-1) - Remove vacuous length assertion in tftest that tested its own input, not the module behavior (DEREM-2) - Replace em-dash with period in test comment (DEREM-3)
35C4n0r
force-pushed
the
35C4n0r/feat-codex-remote-mcp
branch
from
3247275 to
594256f
Compare
|
/coder-agents-review |
There was a problem hiding this comment.
Second-pass review (Netero). R1 findings (DEREM-1 through DEREM-3) all addressed in 594256f. 1 new P2, 1 new P3, 1 new Nit.
The jq guard, vacuous assertion removal, and em-dash fix are clean. Three new findings on the updated code.
Note: CI has a failing "Validate Terraform output" check (job 76721444744). The module's outputs are unchanged by this PR, so the failure may be unrelated, but worth investigating.
This is a first-pass review only. These are mechanical findings from Netero. The full review panel has not yet reviewed this PR and will review after these findings are addressed.
🤖 This review was automatically generated with Coder Agents.
|
I wonder if we can hold onto this in favor of handling it implicitly using https://developers.openai.com/codex/enterprise/managed-configuration |
35C4n0r
force-pushed
the
35C4n0r/feat-codex-remote-mcp
branch
from
47f2c36 to
3d31e31
Compare
…ig_remote_path is configured
…-block markers before appending
… user-facing error message
35C4n0r
force-pushed
the
35C4n0r/feat-codex-remote-mcp
branch
from
f36581c to
575c670
Compare
35C4n0r
force-pushed
the
35C4n0r/feat-codex-remote-mcp
branch
from
2631fd7 to
7a6b5db
Compare
35C4n0r
added
version:minor
3 participants
Description
Type of Change
Module Information
Path:
registry/coder-labs/modules/codexNew version:
v5.3.0Breaking change: [ ] Yes [ ] No
Testing & Validation
bun test)bun fmt)Related Issues
Closes #886